Fix for comparisons of categorical and an scalar not in categories #9864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, a comparison of categorical data and a scalar, which is not in the categories would return `False` for all elements when it should raise a `TypeError`, which it now does. Also fix that `!=` comparisons would return `False` for all elements when the more logical choice would be `True`.
|
Still asking why equality doesn't raise when comparing with a non-existing category. |
Member
|
@kay1793 This is consistent with what Python does for non-comparable types: |
|
thanks. |
Contributor
|
merged via 35b20d8 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, a comparison of categorical data and a scalar, which
is not in the categories would return
Falsefor all elements whenit should raise a
TypeError, which it now does.Also fix that
!=comparisons would returnFalsefor all elementswhen the more logical choice would be
True.Fixes the raised issue in #9836 (comment)